Improve error handling in transpile command #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2IMT
commented
Dec 16, 2024
2IMT
commented
- Catch all other errors in transform() function and report them to the user
- Improve error messages for non-existent or invalid foreign files
|
@maxonfjvipon, could you please review? |
|
@maxonfjvipon please, take a look |
maxonfjvipon
requested changes
Dec 20, 2024
| if (options.verbose) { | ||
| console.log(`Skipping ${pth} - already transpiled`); | ||
| } | ||
| return; |
There was a problem hiding this comment.
@2IMT we're trying to avoid multiple return statements, here's why: https://www.yegor256.com/2015/08/18/multiple-return-statements-in-oop.html
| } | ||
| if (!foreign.endsWith('.json')) { | ||
| throw new Error(`Only .json foreign tojos file is supported, given ${foreign.substring(foreign.lastIndexOf(path.sep))}`) | ||
| throw new Error(`Invalid foreign tojo file format: ${foreign.substring(foreign.lastIndexOf(path.sep))}. Only .json files are supported.`); |
There was a problem hiding this comment.
@2IMT I don't understand the purpose of the change
| @@ -122,10 +133,10 @@ const transpile = function(options) { | |||
| const foreign = path.resolve(options['target'], options['foreign']) | |||
| console.log(`Reading foreign tojos from: ${foreign}`) | |||
| if (!fs.existsSync(foreign)) { | |||
| throw new Error(`File ${foreign} is not found`) | |||
| throw new Error(`File not found: ${foreign}. Ensure the file exists and is accessible.`) | |||
There was a problem hiding this comment.
@2IMT I don't understand the purpose of the change
|
@2IMT It is not a good idea to name Git branches the way you named this one: " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.