Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed clean message bug #383

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

mpa-LHutchinson
Copy link
Contributor

@mpa-LHutchinson mpa-LHutchinson commented Nov 19, 2024

I made a fix for issue #382 by moving the line that deletes the directory

fs.rmSync(home, {recursive: true, force: true});

to only execute after checking if it exists. Before it would delete the directory, then check if it exists, and because it was already deleted it would always give the message

The directory .eoc doesn't exist, no need to delete


PR-Codex overview

This PR focuses on enhancing the logging functionality in the clean.js command by providing feedback on the deletion status of a directory.

Detailed summary

  • Added a log message to inform when the directory has been successfully deleted: console.info('The directory %s deleted', rel(home));
  • Retained the log message for when the directory does not exist: console.info('The directory %s doesn\'t exist, no need to delete', rel(home));

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256 yegor256 merged commit 3d49141 into objectionary:master Nov 20, 2024
7 of 13 checks passed
@yegor256
Copy link
Member

@mpa-LHutchinson thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants