-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#889): Optimize Disassemble/Assemble Goals #924
feat(#889): Optimize Disassemble/Assemble Goals #924
Conversation
@yegor256 Could you review these changes, please? I guess, |
@volodya-lombrozo looks good, but maybe it's better to fix the performance problem in the |
@volodya-lombrozo I can't understand where the performance gain is coming from? |
@yegor256 Sure, I left the ticket for it jcabi/jcabi-xml#277 |
@yegor256 It's an open question, we need to investigate it separately. |
@yegor256 Can I merge these changes? |
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 10min). |
In this PR I optimize
disassemble/assemle
goals to speed up development.Timings after optimization:
As you can see, in some cases we got ~ x10 speed up.
Related to #889.