Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#889): Optimize Disassemble/Assemble Goals #924

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Nov 29, 2024

In this PR I optimize disassemble/assemle goals to speed up development.

Timings after optimization:

[INFO]           spring-fat/pom.xml ............................... SUCCESS (301.7 s)
[INFO]           spring-fat/pom.xml ............................... SUCCESS (313.2 s)
[INFO]           spring-fat/pom.xml ............................... SUCCESS (378.5 s)

As you can see, in some cases we got ~ x10 speed up.

Related to #889.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you review these changes, please? I guess, eo repository has the same problems as well. It might be interesting for you.

@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

@volodya-lombrozo looks good, but maybe it's better to fix the performance problem in the com.jcabi.xml.XMLDocument class?

@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

@volodya-lombrozo I can't understand where the performance gain is coming from? XMLDocument also encapsulates Node (not a String).

@volodya-lombrozo
Copy link
Member Author

@volodya-lombrozo looks good, but maybe it's better to fix the performance problem in the com.jcabi.xml.XMLDocument class?

@yegor256 Sure, I left the ticket for it jcabi/jcabi-xml#277

@volodya-lombrozo
Copy link
Member Author

@volodya-lombrozo I can't understand where the performance gain is coming from? XMLDocument also encapsulates Node (not a String).

@yegor256 It's an open question, we need to investigate it separately.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Can I merge these changes?

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 2, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 717f728 into objectionary:master Dec 2, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 2, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 10min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants