Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD QC check that checks whether a new class added is in the CL ID space #763

Closed
matentzn opened this issue Oct 1, 2020 · 4 comments
Closed
Assignees
Labels

Comments

@matentzn
Copy link
Contributor

matentzn commented Oct 1, 2020

No description provided.

@paolaroncaglia
Copy link
Contributor

@matentzn I assume that this can be closed, too.

@matentzn
Copy link
Contributor Author

I wouldnt even know how to solve this.. Very difficult. For whoever in techland wants to pick this up, this is my idea:

Any class in the cl-base.owl file with a label must match the following pattern (roughly):

http://purl.obolibrary.org/obo/CL_[0-9]{7}

Add sparql query to that end. For when you are bored @anitacaron :)

@gouttegd
Copy link
Collaborator

Re-use the check implemented in Uberon.

@matentzn
Copy link
Contributor Author

matentzn commented Jan 6, 2025

Lets wait for the next time someone adds a wrong ID.

@gouttegd suggested to use GHA to look at diff (robot diff) and look for declaration axioms.

@Caroline-99 if you like to deal with this issue feel free, but I think there might be more important "good first tech issues"

@matentzn matentzn closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants