Add ID format check #2747
Merged
Add ID format check #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to ensure that CL IDs follow the expected format.
matentzn
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports for CL the same “ID format check” already used in Uberon, to ensure that CL IDs follow the expected format
http://purl.obolibrary.org/obo/CL_[0-9]{7}.This is a partial fix to #763, though it does not fully implement what was requested there. The requested check was to ensure that no class could be added with an ID in a namespace other than the CL namespace -- something that is actually tricky to check because of the imported classes.
Here, we are simply checking that, if a class is in the CL namespace, it follows the expected format. That is, the check would catch a bogus ID like
http://purl.obolibrary.org/obo/CL_12345678(8 digits instead of 7), but not an ID likehttp://purl.obolibrary.org/obo/NOTCL_1234567(not in the CL namespace).