handle degenerate domains #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the test snapshots changed… maybe I’m running a new version of Node? 🤔 |
|
Yes that's the reason. Same for me aaa8324 passes all tests with v21.6.0, but not v22.10.0. Probably the maths have changed :) Means we have to round a bit before we compare numbers… it's going to be fun. |
|
can we go back to aaa8324 and leave the tests aside for now? The fix lgtm! |
|
Yeah we’re stuck on Node 20 for development until we either drop node-canvas or they release 3.0.0. #2234 So we’ll need to generate the snapshots on Node 20. |
mbostock
force-pushed
the
mbostock/degenerate-domains
branch
from
cecea00 to
9da8083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210. Alternative to #2211.