Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand readme #30

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Expand readme #30

merged 4 commits into from
Oct 18, 2023

Conversation

random-person-001
Copy link
Contributor

No description provided.

@random-person-001 random-person-001 mentioned this pull request Oct 16, 2023
Closed
2 tasks
@random-person-001
Copy link
Contributor Author

random-person-001 commented Oct 16, 2023 •
edited
Loading

Looking for approval for the direction I went with this, and also feedback on some of the smaller bits. If the larger picture is ok, the tweaks needed are:

  • write out instructions on making a pr/commit in browser
  • if we decide we should, talk about acceptable content more
  • if we decide we should, talk about attribution more/rephrase

@peytondmurray
Copy link
Collaborator

peytondmurray commented Oct 16, 2023 •
edited
Loading

write out instructions on making a pr/commit in browser

Also what makes an appropriate/useful commit message, keeping in mind that it will be displayed on each page

peytondmurray
peytondmurray approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise looks good.

README.md Outdated Show resolved Hide resolved
@random-person-001 random-person-001 merged commit 2d27149 into main Oct 18, 2023
1 check passed
@random-person-001 random-person-001 deleted the random-person-001-patch-1 branch October 18, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray Awaiting requested review from peytondmurray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@random-person-001 @peytondmurray