Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linkcheck job to CI #43

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add linkcheck job to CI #43

merged 2 commits into from
Oct 18, 2023

Conversation

peytondmurray
Copy link
Collaborator

@peytondmurray peytondmurray commented Oct 18, 2023 •
edited
Loading

This PR adds a linkcheck job to CI. Closes #22.

I've also changed a bunch of implicit links have been turned into explicit links with <>.

random-person-001
random-person-001 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@random-person-001 random-person-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just a question about newline wrapping article content

src/beginning/telescope.md Outdated Show resolved Hide resolved
random-person-001
random-person-001 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@random-person-001 random-person-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linewrapping markdown comments causes some problems - not that can't be solved, but to be noted

@peytondmurray peytondmurray force-pushed the fail-build-on-broken-refs branch 2 times, most recently from 95cae4a to 3b22689 Compare October 18, 2023 18:51
@peytondmurray peytondmurray force-pushed the fail-build-on-broken-refs branch from 3b22689 to 8087838 Compare October 18, 2023 18:53
random-person-001
random-person-001 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@random-person-001 random-person-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@peytondmurray peytondmurray merged commit dac33c8 into observational-dev:main Oct 18, 2023
@peytondmurray peytondmurray deleted the fail-build-on-broken-refs branch October 18, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-person-001 random-person-001 random-person-001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dead links stand out
2 participants
@peytondmurray @random-person-001