Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 page #48

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

peytondmurray
Copy link
Collaborator

@peytondmurray peytondmurray commented Oct 22, 2023

This PR adds a 404 page. Closes #31.

sphinx-notfound-page is added as a dependency. Unfortunately this is annoying to test locally, it's easier just to merge this and make a fix if needed. I followed the instructions on that page, so I think everything should work.

src/conf.py Outdated
@@ -67,6 +68,8 @@

html_static_path = ["_static"]

notfound_urls_prefix = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building locally, I get the warning

The config value `notfound_urls_prefix' has type `NoneType', defaults to `str'.
make: *** [Makefile:26: html] Error 2

which is treated as an error which fails the build.

Changing it to an empty string made the build succeed, but I do not know if it will have the same effect.

notfound_urls_prefix to an empty string instead of None, to avoid build warnings/errors
@random-person-001 random-person-001 merged commit 1caccbc into observational-dev:main Oct 22, 2023
2 checks passed
@random-person-001
Copy link
Contributor

Looks like it works!

@peytondmurray peytondmurray deleted the add-404-page branch October 22, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a 404 page
2 participants