Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for "headless" mode #109

Open
1 of 4 tasks
phated opened this issue Sep 1, 2020 · 0 comments
Open
1 of 4 tasks

Improvements for "headless" mode #109

phated opened this issue Sep 1, 2020 · 0 comments

Comments

@phated
Copy link
Contributor

phated commented Sep 1, 2020

An extrapolation on #108, I've made some observations on how this package could help enable publishing from CI:

  • Accept GitHub token from environment (ref Accept GitHub Token from the environment? #108)
  • Option to disable opening browser upon PR creation. Currently the command crashes if open or xdg-open exists but doesn't succeed.
  • Check if git user & email are set so the commit command doesn't fail without a good error message. Optionally accept a user and email at command line to use for commit.
  • Allow configurable protocol, or always use https and append token to the command for pushes. e.g. git remote add user https://[email protected]/phated/opam-repository will work because the GitHub Token used for forking will also allow pushes to that repository.

My working GitHub Actions template (with workarounds) is at https://github.com/grain-lang/binaryen.ml/blob/e2fb4dafa5cf90757c6183409ca04edc76d84db1/.github/workflows/opam-publish.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant