Add --no-browser flag #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything I can do to help move this forward? |
|
My understanding is that this PR does not change the default behavior, which is to open a browser, but provides an option to disable it. Maybe the option should be more explicit, like |
|
Sure, I can make that change! I was thinking about making it |
|
@lefessan Just made those changes. Is this what you were looking for? |
dra27
reviewed
Sep 14, 2020
|
Sorry for the delay here (I've been in interviews all week). I've updated the PR as per the review. Thanks! |
dra27
approved these changes
Sep 18, 2020
|
Good for me too! Thanks |
rjbou
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #109
This adds an option called
--open-browserthat a user can set to false to disable the open browser logic in a headless environment.