Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ppat_cons parenthesization in function parameter position #2476

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix Ppat_cons parenthesization in function parameter position #2476

merged 2 commits into from
Nov 7, 2023

Conversation

tdelvecchio-jsc
Copy link
Contributor

Fixes #2475.

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Nov 7, 2023
@gpetiot gpetiot changed the title Fix Ppat_cons parenthesization in function parameter position. Fix Ppat_cons parenthesization in function parameter position Nov 7, 2023
gpetiot
gpetiot approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This has been introduced in #2471, so no need to add a changelog entry, but I added the test case from the issue.

@gpetiot gpetiot merged commit 5f796f2 into ocaml-ppx:main Nov 7, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpetiot gpetiot gpetiot approved these changes

Assignees
No one assigned
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Error on Ppat_cons in function parameter
2 participants
@tdelvecchio-jsc @gpetiot