Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report stale occurrences #1885

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

liam923
Copy link
Contributor

@liam923 liam923 commented Jan 10, 2025

This PR does two things:

  1. Fix a bug with Merlin's detection of stale occurrences. Currently, depending on the layout of a repository, Merlin may not line up file paths correctly.
  2. Currently, Merlin discards any occurrences it thinks might be stale. This PR changes this so that the stale occurrences are reported, but flagged as being stale.

The net effect for an end user should be nothing - the stale occurrences should still be reported by their editor. But this enables future LSP/editor work.

The reason these two items are in the same PR is:

  • Doing just (1) would result in stale occurrences no longer being reported at all.
  • Doing just (2) would be hard to test.

I encourage reviewing commit-by-commit. The tests pass after each commit, and changes (1) and (2) are separated into separate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant