gles3 initial versions #5894

craff · 2016-03-07T10:30:16Z

I restarted from a fresh fork ... and now have a clean patch (I hope)

gles3.20160307.alpha - via opam-publish

camelus · 2016-03-07T10:32:12Z

✅ All lint checks passed `3c463e9`

These packages passed lint tests: gles3.20160307.alpha

✅ Installability check (4577 → 4578)

new installable packages (1): gles3.20160307.alpha

craff · 2016-03-07T12:41:58Z

I see that some test fails ... but I can't access any details ... How can I know what's happening ,

dsheets · 2016-03-07T12:45:22Z

I think if you click Show all checks and then Details next to continuous-integration/travis-ci/pr, you will be taken to https://travis-ci.org/ocaml/opam-repository/builds/114206682 which shows all the test runs.

On Linux:

### stderr ###
Found params: num = 156, size = 313, mask = 0x43A
# Probes: max = 3, sum = 42
# ml_gles3.c:31:23: fatal error: GLES3/gl3.h: No such file or directory
# compilation terminated.
# make: *** [ml_gles3.o] Error 1

On OS X:

### stderr ###
Found params: num = 156, size = 313, mask = 0x43A
# Probes: max = 3, sum = 42
# ml_gles3.c:25:10: fatal error: 'caml/misc.h' file not found
# #include <caml/misc.h>
#          ^
# 1 error generated.
# make: *** [ml_gles3.o] Error 1

dsheets · 2016-03-07T12:46:40Z

packages/gles3/gles3.20160307.alpha/opam

+  "Christophe Raffalli <[email protected]>, Alexandre Miquel<[email protected]>"
+homepage: "http://lama.univ-savoie.fr/~raffalli/gles3"
+bug-reports: "[email protected]"
+license: "LGPL"


Could you please specify the version of the LGPL license and whether you intend to use the "OCaml linking exception"?

dsheets · 2016-03-07T12:49:10Z

Please see the other comments on #5893. Also, you can simply force-push to a branch that is the source of a pull request to update it instead of creating a new branch and a new pull request. This helps to keep the conversation about the PR in one place and reduce the volunteer effort required to review submissions.

craff · 2016-03-07T13:43:23Z

I did not see all comment, sorry.
I fixed the LGPL ...
However, I do not understand this comment:

packages/gles3/gles3.20160307.alpha/url
@@ -0,0 +1,3 @@
+http:

"https://lama.univ-savoie.fr/~raffalli/gles3/gles3-20160307.alpha.tar.gz"
@dsheets OCaml member
dsheets added a note 4 hours ago

I believe this can be archive: in order to maintain flexibility in transport.

dsheets · 2016-03-07T13:50:22Z

It is very minor but http: (opam field) specifies the transport protocol which is already included in the URL as https: (URI scheme). See https://opam.ocaml.org/doc/manual/dev-manual.html#sec10 which discusses the various url file fields and their meanings. archive will use the URL whereas http is a repetition of the type declaration and becomes another component to update if the archive location changes how it is hosted.

With all that said, lots of other packages use http: where archive: would be more appropriate so it's not very important.

dsheets · 2016-03-07T13:54:02Z

... and I see that this is probably an opam-publish issue. Sorry to bother you, @craff.

craff · 2016-03-07T14:13:58Z

I have stopped to use opam-publish ... to me it should just git commit to your own fork of the opam-repository ... The pull request can be manual ... My changes are coming soon

craff · 2016-03-07T14:52:50Z

### stderr ###
Found params: num = 156, size = 313, mask = 0x43A
# Probes: max = 3, sum = 42
# ml_gles3.c:31:23: fatal error: GLES3/gl3.h: No such file or directory
# compilation terminated.
# make: *** [ml_gles3.o] Error 1

This is normal if GLES3 is not installed on the machine ?

craff · 2016-03-07T14:53:41Z

### stderr ###
Found params: num = 156, size = 313, mask = 0x43A
# Probes: max = 3, sum = 42
# ml_gles3.c:25:10: fatal error: 'caml/misc.h' file not found
# #include <caml/misc.h>
#          ^
# 1 error generated.
# make: *** [ml_gles3.o] Error 1

This looks to me like a wrong ocaml installation ... moreover, I do not expect gles3 to work on OSX so easily ?

ghost · 2016-03-07T15:08:32Z

For the missing header, what we usually do is a second "configuration" package, that checks the header avaibility and provides information about the corresponding "system package" on usual distros. See for instance:

https://github.com/ocaml/opam-repository/blob/master/packages/conf-cairo/conf-cairo.1/opam

In particular, the depext field is used by the CI to install the required system package.

ghost · 2016-03-07T15:14:47Z

If the library is not supposed to compile on OS X, you might add available: [ os != "darwin" ] in the OPAM package description.

craff · 2016-03-07T16:47:41Z

I think the package should be ok ... except that I don't know how to produce the depexts for all distribution on earth ;-)

ghost · 2016-03-07T17:25:27Z

You already added quite a few distro in depexts, thanks :-)

Unfortunatly, the CI failed because the header file GLES/gl3.h is not available on Ubuntu/Precise (which is used by the CI). It only appeared with Trusty. I am not aware of any mechanism in OPAM to handle that, so the package looks good to me. I am just waiting for someone to confirm that before merging, @dsheets ?

Thanks again for submitting the package !

dsheets · 2016-03-07T17:32:26Z

@OCamlPro-Henry you are correct. LGTM.

dsheets · 2016-03-07T17:33:46Z

Oh, one last thing, it might be nice to include a post-messages field in the failure condition to explain possible reasons. See https://opam.ocaml.org/doc/manual/dev-manual.html#sec9 search for post-messages.

dsheets · 2016-03-07T17:38:26Z

I've open ocaml-opam/Camelus#7 to track the depext/post-messages best practice policy.

craff · 2016-03-07T18:46:36Z

I added post-messages. We can not ask a minimal version in depexts ? This would make
gles3 unavailable under ubuntu 12.04 or before ?

dsheets · 2016-03-07T19:37:18Z

Unfortunately, we don't currently have versioning incorporated into the depext system due to complexity of the interface task. Some level of this kind of functionality is certainly possible and I have open ocaml-opam/opam-depext#43 to track that.

craff · 2016-03-07T21:43:56Z

s/or/os/ done

craff · 2016-03-08T05:03:38Z

By the way, the typo s/or/os did not give an error when I installed the package from by own
git repository ... Why ?

dsheets · 2016-03-08T09:41:01Z

No error is generated because or is a valid (but unbound) variable name. I've opened ocaml-opam/Camelus#8 for this.

craff · 2016-03-08T10:46:40Z

Is the package OK now or do you have more suggestion ?

gles3 initial versions

craff · 2016-03-08T10:50:47Z

Thanks !

ghost · 2016-03-08T10:50:53Z

LGTM, thanks for introducing the post-message !

craff · 2016-03-08T10:57:09Z

And thanks again for all the help with opam ...

As an aside question: opam2debian is still alive ? It is not in the opam repository. I think tools like opam2x
where x would range in the depexts of the package would be a must ... This tool could even use opam
for build and/or install the package of some distros.

One could even imagine that all opam package automatically become package for
all distro (except if we do not want that).

Christophe Raffalli and others added 2 commits March 7, 2016 11:28

gles3.20160307.alpha - via opam-publish

1ae74f1

Merge pull request #1 from craff/opam-publish/gles3.20160307.alpha

364b5e7

gles3.20160307.alpha - via opam-publish

dsheets reviewed Mar 7, 2016
View reviewed changes

fixed bug + opam package

8edb2a4

forgotten "" in url

567177d

Christophe Raffalli added 5 commits March 7, 2016 16:32

fixed gles3 url file

41060d4

added ox != darwin and depexts for gles3

b28a65b

gles3/opam again

3d73aee

gles3/opam again

f56536d

gles3/opam again

fbb27b0

gles3:post-messages

d0ba7d5

gles3:type

3c463e9

ghost pushed a commit that referenced this pull request Mar 8, 2016

Merge pull request #5894 from craff/master

c7ac1fc

gles3 initial versions

ghost merged commit c7ac1fc into ocaml:master Mar 8, 2016

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gles3 initial versions #5894

gles3 initial versions #5894

craff commented Mar 7, 2016

camelus commented Mar 7, 2016

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 7, 2016

ghost commented Mar 7, 2016

ghost commented Mar 7, 2016

craff commented Mar 7, 2016

ghost commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 8, 2016

dsheets commented Mar 8, 2016

craff commented Mar 8, 2016

craff commented Mar 8, 2016

ghost commented Mar 8, 2016

craff commented Mar 8, 2016

gles3 initial versions #5894

gles3 initial versions #5894

Conversation

craff commented Mar 7, 2016

camelus commented Mar 7, 2016

✅ All lint checks passed 3c463e9

✅ Installability check (4577 → 4578)

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets Mar 7, 2016

Choose a reason for hiding this comment

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 7, 2016

ghost commented Mar 7, 2016

ghost commented Mar 7, 2016

craff commented Mar 7, 2016

ghost commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

dsheets commented Mar 7, 2016

craff commented Mar 7, 2016

craff commented Mar 8, 2016

dsheets commented Mar 8, 2016

craff commented Mar 8, 2016

craff commented Mar 8, 2016

ghost commented Mar 8, 2016

craff commented Mar 8, 2016

✅ All lint checks passed `3c463e9`