Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: respect the DUNE_CACHE_ROOT environment variable if it exists #6326

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Dec 5, 2024

Users can set DUNE_CACHE_ROOT, which has a higher priority than other environment variables.
Currently, there are some cases where the cache functionality does not work well when DUNE_CACHE_ROOT is set.

Ref: https://dune.readthedocs.io/en/stable/caching.html

@smorimoto smorimoto force-pushed the respect-dune-cache-root branch from 52576ac to 7423bf4 Compare December 5, 2024 22:07
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Dec 6, 2024
@kit-ty-kate kit-ty-kate force-pushed the respect-dune-cache-root branch from 7423bf4 to 392dbc4 Compare December 6, 2024 10:09
@kit-ty-kate kit-ty-kate force-pushed the respect-dune-cache-root branch from 392dbc4 to 400b2f6 Compare December 6, 2024 10:10
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bubblewrap (linux) sandbox script also needed to be changed but i've done it. lgtm

@smorimoto
Copy link
Member Author

Thanks a lot!

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 7b0e23f into ocaml:master Dec 6, 2024
42 checks passed
@smorimoto smorimoto deleted the respect-dune-cache-root branch December 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants