Skip to content

Commit

Permalink
Merge pull request #841 from oceanzus/redesign_sprint14_13254_rev
Browse files Browse the repository at this point in the history
Reverts ticket 13254 to support Sprint 14 fixes to ZPLSC data fetching.
  • Loading branch information
oceanzus authored Aug 22, 2018
2 parents 78322f2 + 0d99a72 commit 1571772
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- "0.8"
- "0.10"
- "7"
script: 'true'
before_install:
- npm install -g grunt-cli
- npm install -g grunt-cli
8 changes: 4 additions & 4 deletions ooiui/static/js/partials/science/plot/PlotControls.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@
<% //console.log(option.get('value')); %>
<% //console.log((model.get('ref_des').indexOf('ZPLSC') > -1) && (option.get('value') == 'xy')); %>
<!-- TODO: Remove this ZPLSC-specific check once we can retrieve data from uframe correctly -->
<% if ((model.get('ref_des').indexOf('ZPLSC') > -1) && (option.get('value') == 'xy')){ %>
<% //if ((model.get('ref_des').indexOf('ZPLSC') > -1) && (option.get('value') == 'xy')){ %>
<option value="<%=option.get('value')%>" <%= option.get('value') == plotModel.get('plotType') ? 'selected' : ''%>><%= option.get('name') %></option>
<% }else if ((model.get('ref_des').indexOf('ZPLSC') === -1)){ %>
<option value="<%=option.get('value')%>" <%= option.get('value') == plotModel.get('plotType') ? 'selected' : ''%>><%= option.get('name') %></option>
<% } %>
<% //}else if ((model.get('ref_des').indexOf('ZPLSC') === -1)){ %>
<!--<option value="<%=option.get('value')%>" <%= option.get('value') == plotModel.get('plotType') ? 'selected' : ''%>><%= option.get('name') %></option>-->
<% //} %>
<% }); %>

<% }else { %>
Expand Down
7 changes: 7 additions & 0 deletions ooiui/static/json/uiPatchNotes.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
[
{
"VersionNumber": "1.4.10",
"VersionDate": "2018-07-24",
"VersionDescription": [
"Plotting: Reversion of ZPLSC XY-only plotting. (13254)"
]
},
{
"VersionNumber": "1.4.9.3",
"VersionDate": "2018-06-14",
Expand Down

0 comments on commit 1571772

Please sign in to comment.