Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to gui to add buttons to clear plot and clear parameters, remov… #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bkuebel
Copy link

@bkuebel bkuebel commented Jan 5, 2021

…e unwanted parameters from list, add yellow/red lines for suspect/fail data, and add button to Find Gaps, print out longest data gap, and add an annotation if the time period of the data gap isn't already annotated

…e unwanted parameters from list, add yellow/red lines for suspect/fail data, and add button to Find Gaps, print out longest data gap, and add an annotation if the time period of the data gap isn't already annotated
@bkuebel bkuebel requested review from cwingard and snwhite January 5, 2021 23:15
cwingard
cwingard previously approved these changes Jan 5, 2021
Copy link
Member

@cwingard cwingard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to download the mlapp to my computer to play with it. It works with my data, looks nice!

@cwingard
Copy link
Member

@bkuebel I played around with this some more with a phsen data set. The new sorting method you have for the variables removes several other ones that are needed/desired. Your function removes everything that isn't named raw*, practical*, density* or seawater*. That means I can't see most of the variables I need to look at for the phsen. I suggest changing the function to:

% Button pushed function: LoadDataButton
function LoadDataButtonPushed(app, event)
    persistent lastpath
    if isempty(lastpath) 
        lastpath = 0;
    end

    if lastpath == 0
        [filename, pathname] = uigetfile('*.nc', 'Select NetCDF File');
    else
        [filename, pathname] = uigetfile('*.nc', 'Select NetCDF File', lastpath);
    end

    if pathname ~= 0
        lastpath = pathname;
        data = nc_reader(fullfile(pathname, filename));

        % Remove the *_qc_executed and *_qartod_executed string parameters
        ind = ~endsWith(data.Properties.VariableNames, {'executed'});
        ind2keep = ind == 1;
        app.ParametersListBox.Items = data.Properties.VariableNames(ind2keep);
        setappdata(app.LeftPanel, 'ncdata', data);
        setappdata(app.LeftPanel, 'ncfile', filename);
        app.PlotButton.Enable = true;
    end
end

Also, in your find gapsand theplotfunctions, the date/time string needs to include theTbetween the date and the time. That format is how the API delivers the date/time string and howit expects the string to be formatted (e.g.2021-01-19T16:16:00`). If you can update the data_review.mlapp to include these changes and push the commit to the gui_edits branch, we can give it another check.

… fixed fill of yellow/red behind suspect/fail data, and added button to Clear Annotations
cwingard added a commit that referenced this pull request Feb 2, 2021
Merge pull request #5 from WHOIGit/master
bkuebel and others added 4 commits February 22, 2021 12:24
…e unwanted parameters from list, add yellow/red lines for suspect/fail data, and add button to Find Gaps, print out longest data gap, and add an annotation if the time period of the data gap isn't already annotated
… fixed fill of yellow/red behind suspect/fail data, and added button to Clear Annotations
@cwingard
Copy link
Member

cwingard commented Mar 4, 2021

@bkuebel @snwhite Updated the pull request with changes to both the nc_reader function:

  • address some bugs in the NetCDF library used by Matlab
  • properly supports string variables like the *_qartod_executed variables we will now be using
  • changes how the date/time was being calculated
    Also made a few changes to the data_review app:
  • addresses bug identified by Sheri White when saving a downloaded file (didn't auto-generate the file name on the second save)
  • adds ability to append deployments (must be the same data record with the same variables) to allow for cross-deployment assessments.
  • removes string variables from the list of variables (can't support those at this time, and they throw an error).

@cwingard cwingard self-requested a review May 3, 2021 18:45
Copy link
Member

@cwingard cwingard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkuebel Lets cancel this PR. The code has been moved into the ooi-data-explorations repo and has long since been updated past this particular PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants