Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13299 Asyncronous download of specific parameters to CSV and N… #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #13299 Asyncronous download of specific parameters to CSV and N… #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae752b
Issue #13299 Asyncronous download of specific parameters to CSV and N…
mfegan Jul 24, 2018
c23bd2f
Issue #13299 Asyncronous download of specific parameters to CSV and N…
mfegan Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions util/jsonresponse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,11 @@ def _deployment_particles(self, ds, stream_key, parameters, external_includes):
if lat_data is not None and lon_data is not None:
data['lat'] = lat_data
data['lon'] = lon_data
params.extend(('lat', 'lon'))
# always include lat/lon
params.extend(('lat', 'lon'))
Copy link
Contributor

@danmergens danmergens Jul 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to include lat/lon when we do not have values for them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 127 - 132 apply to gliders only and essentially rename GPS based lat/lon as simply lat or lon. Some non-glider data does have lat/lon, e.g. GI01SUMO_RID16_02_FLORTD000, which were not being reported. At this point, we are actually saying we want to include lat/lon; if they are not available, they are reported as missing in lines 161 - 163 and removed from the requested param list in 165.

I think it is more efficient to do this than to attempt to determine ahead of time if lat/lon are available.


# remaining externals

# remaining externals.
for sk in external_includes:
for param in external_includes[sk]:
name = '-'.join((sk.stream_name, param.name))
Expand Down