Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipfs CID. #1851

Merged
merged 26 commits into from
Oct 9, 2024
Merged

Fix ipfs CID. #1851

merged 26 commits into from
Oct 9, 2024

Conversation

mariacarmina
Copy link
Member

Fixes #1849 .

Changes proposed in this PR:

@mariacarmina mariacarmina self-assigned this Sep 19, 2024
@mariacarmina mariacarmina marked this pull request as ready for review October 7, 2024 18:40
.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/services/Provider.ts Outdated Show resolved Hide resolved
src/services/Provider.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/integration/PublishEditConsume.test.ts Outdated Show resolved Hide resolved
test/integration/helpers.ts Outdated Show resolved Hide resolved
test/integration/PublishEditConsume.test.ts Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 8, 2024

Code Climate has analyzed commit a690f6d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.5% (-0.2% change).

View more on Code Climate.

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariacarmina mariacarmina merged commit 9c25342 into main Oct 9, 2024
11 checks passed
@mariacarmina mariacarmina deleted the fix-ipfs-test branch October 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ipfs test
3 participants