Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confidential EVM flag when creating a datatoken 4 in NFT class #1859

Merged
merged 29 commits into from
Oct 16, 2024
Merged

Add confidential EVM flag when creating a datatoken 4 in NFT class #1859

merged 29 commits into from
Oct 16, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Oct 3, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • Wrap signer for every contract function

@mariacarmina mariacarmina self-assigned this Oct 3, 2024
@mariacarmina mariacarmina mentioned this pull request Oct 3, 2024
Merged
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from 218cc1b to d086738 Compare October 7, 2024 13:01
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from 601d2ee to 93c59b4 Compare October 7, 2024 15:12
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from 8598638 to 0577262 Compare October 8, 2024 10:47
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from ab0cafb to c16ee96 Compare October 8, 2024 18:40
@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 9, 2024

Code Climate has analyzed commit 87e1f9a and detected 66 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 62

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.8% (-2.7% change).

View more on Code Climate.

@mariacarmina mariacarmina mentioned this pull request Oct 9, 2024
Merged
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from 8eb7923 to e45bad9 Compare October 14, 2024 08:43
@github-actions github-actions bot force-pushed the confidential-evm-nft-class branch 2 times, most recently from fe425bf to 7a02957 Compare October 14, 2024 08:53
@mariacarmina mariacarmina force-pushed the confidential-evm-nft-class branch from 91233a3 to a79b137 Compare October 14, 2024 09:00
@github-actions github-actions bot force-pushed the confidential-evm-nft-class branch from b58340e to de576a6 Compare October 14, 2024 09:10
@github-actions github-actions bot force-pushed the confidential-evm-nft-class branch from d2650b7 to 9ffee5a Compare October 14, 2024 09:15
paulo-ocean
paulo-ocean approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
but i think we have to check why the tests are not running

@jamiehewitt15
Copy link
Member

we have to check why the tests are not running

Yeah, what's the deal with the tests?

@mariacarmina
Copy link
Member Author

mariacarmina commented Oct 16, 2024 •
edited
Loading

lgtm, but i think we have to check why the tests are not running

I think it's due to the fact that I forced-pushed some commits, because some READMEs were updated on my branch, pulled the changes and still I couldn't push the modifications, so I forced pushing the commits. Tests were passing for b58340e which is the latest commit

@mariacarmina mariacarmina merged commit a0a8df3 into main Oct 16, 2024
@mariacarmina mariacarmina deleted the confidential-evm-nft-class branch October 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariacarmina @jamiehewitt15 @bogdanfazakas @paulo-ocean