Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate types to dist/types #1862

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

FilipMasar
Copy link
Collaborator

@FilipMasar FilipMasar commented Oct 17, 2024

Fixes #1850

Changes proposed in this PR:

  • generate types declaration in dist/types
  • fix path to tests tsconfig in eslint

Copy link

codeclimate bot commented Oct 17, 2024

Code Climate has analyzed commit bae1874 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.6% (0.0% change).

View more on Code Climate.

@FilipMasar FilipMasar marked this pull request as ready for review October 17, 2024 20:52
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit dc64981 into main Oct 30, 2024
11 checks passed
@paulo-ocean paulo-ocean deleted the 1850-add-a-type-declaration-file branch October 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a type declaration file
4 participants