Add back check for access list factory.

[mariacarmina]

Fixes # .

Changes proposed in this PR:

From this discussion #1868 (comment), I reopened the topic, that assignement does not check if the accessListFactory exists and throws this error for not EVM chains (for example in barge):
Error publishing asset: Cannot read properties of undefined (reading 'accessListFactory')

[jamiehewitt15]

Looks good to me

[paulo-ocean]

this is definitely NOT OK

This:

if ('accessListFactory' in contractAddressesConfig) {
      config.accessListFactory = contractAddressesConfig.accessListFactory
}
 

Will break if contractAddressesConfig is null or undefined , which was the cause of
Error publishing asset: Cannot read properties of undefined (reading 'accessListFactory')

we cannot search for a property in something that does not exist, fyi:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/in_operator_no_object

You can simply, and safely, do as i suggested above

if(contractAddressesConfig) {
  config.accessListFactory = contractAddressesConfig.accessListFactory
}

Yeah, Paulo makes a good point

[paulo-ocean]

you really like to complicate @mariacarmina , not sure why :-)

This:

if (contractAddressesConfig && 'accessListFactory' in contractAddressesConfig) {
      config.accessListFactory = contractAddressesConfig.accessListFactory
 }

Has exactly the same effect as my suggested change (bellow), except that you made you more complicate (2 checks instead of 1). Can't really understand why but anyway

if(contractAddressesConfig) {
  config.accessListFactory = contractAddressesConfig.accessListFactory
}

[mariacarmina]

you really like to complicate @mariacarmina , not sure why :-)

This:

if (contractAddressesConfig && 'accessListFactory' in contractAddressesConfig) {
      config.accessListFactory = contractAddressesConfig.accessListFactory
 }

Has exactly the same effect as my suggested change (bellow), except that you made you more complicate (2 checks instead of 1). Can't really understand why but anyway

if(contractAddressesConfig) {
  config.accessListFactory = contractAddressesConfig.accessListFactory
}

I do not like to complicate @paulo-ocean :) but as I mentioned previously, the assignment is related to 'accessListFactory' -> so it is good practice to check as well if 'accessListFactory' is present in contractAddressesConfig, because not all the chains have accessListFactory key, because they are not confidential EVM. For me your check is incomplete, we surely need to check if contractAddressesConfig exists, but also if accessListFactory is present because that's what we want to assign. Please check https://github.com/oceanprotocol/contracts/blob/main/addresses/address.json and search 'AccessListFactory' and you'll see that only for oasis that key exists.

[paulo-ocean]

you really like to complicate @mariacarmina , not sure why :-)
This:

if (contractAddressesConfig && 'accessListFactory' in contractAddressesConfig) {
      config.accessListFactory = contractAddressesConfig.accessListFactory
 }

Has exactly the same effect as my suggested change (bellow), except that you made you more complicate (2 checks instead of 1). Can't really understand why but anyway

if(contractAddressesConfig) {
  config.accessListFactory = contractAddressesConfig.accessListFactory
}

I do not like to complicate @paulo-ocean :) but as I mentioned previously, the assignment is related to 'accessListFactory' -> so it is good practice to check as well if 'accessListFactory' is present in contractAddressesConfig, because not all the chains have accessListFactory key, because they are not confidential EVM. For me your check is incomplete, we surely need to check if contractAddressesConfig exists, but also if accessListFactory is present because that's what we want to assign. Please check https://github.com/oceanprotocol/contracts/blob/main/addresses/address.json and search 'AccessListFactory' and you'll see that only for oasis that key exists.

its exactly the same @mariacarmina ... but keep your ideas, i know nothing, just trying to help
but if you're curious :-), try to find the differences https://jsfiddle.net/r9evsbzy//

[mariacarmina]

It worked with npm link on barge