New repo code review

[iowillhoit]

WIP

Review for @W-16891787@

[iowillhoit]

[iowillhoit]

Honestly don't care if you want to rename or delete this new style. Here is the difference:

[iowillhoit]

So far things are looking good! I had two ideas for future features while reviewing:

• iTerm2 supports annotations and is available in ansi-escapes. It would be neat to populate the full value of a line in an annotation if it was truncated.
• For long running async processes, have a "live table" that would populate rows as they came in. This could also resize the table and adjust wraps/truncations if the window was resized. Similar to multi-stage-output

[mdonnalley]

I don't think this is necessary. People can print as many newlines as they want before or after the table. This new line only exists because, otherwise, the next output will appear on the same line as the last line of the table. For example

┌───────┬─────────┬─────┬───────────────────────────────────────────────────────────────────────────┐
│  Id   │  Name   │ Age │                                Description                                │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 36329 │  Alice  │ 20  │  Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod  │
│       │         │     │            tempor incididunt ut labore et dolore magna aliqua.            │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 49032 │   Bob   │ 21  │  Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod  │
│       │         │     │            tempor incididunt ut labore et dolore magna aliqua.            │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 51786 │ Charlie │ 22  │  Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod  │
│       │         │     │            tempor incididunt ut labore et dolore magna aliqua.            │
└───────┴─────────┴─────┴───────────────────────────────────────────────────────────────────────────┘my next line

[mdonnalley]

For long running async processes, have a "live table" that would populate rows as they came in. This could also resize the table and adjust wraps/truncations if the window was resized. Similar to multi-stage-output

I actually had a streaming table working at one point but ripped it out because we didn't think there would be a valid use case inside of sf. I believe the consensus was that any table that had enough data to need streaming would be too big for the terminal. Like if a query in one of the data commands streamed in 1 million records, the user would be able to see those values populate as they came in

[mdonnalley]

iTerm2 supports annotations and is available in ansi-escapes. It would be neat to populate the full value of a line in an annotation if it was truncated.

I really liked this idea but I don't think it's worth implementing.

You have two options: AddAnnotation and AddHiddenAnnotation. If you do the first, then every annotation box will show automatically, which will look messy. If you do the latter, then you can toggle the annotations with cmd + \ but that toggles all of them. Again, too messy