-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
158 notebooks should have access to requesters oda token #248
158 notebooks should have access to requesters oda token #248
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 58.64% 58.88% +0.23%
==========================================
Files 23 23
Lines 4897 4918 +21
==========================================
+ Hits 2872 2896 +24
+ Misses 2025 2022 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the PR is misleading for the moment. It only changes the way how the callback is passed and doesn't deal with the token. To actually use the context file to get a token, the token.py
needs to be updated.
…ariable added to __init__.py
As mentioned, @okolo will look into the failed test (even if it's not because of the changes of this PR) |
Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions? |
What if you just download and run the notebook, does it fail in the same way? |
I've tried to run the notebook in jupyter. The error persists. Here is the notebook output |
Looks like there was some strange behavior with this product on the live instance, must be related to a recent update. |
No description provided.