Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

158 notebooks should have access to requesters oda token #248

Merged

Conversation

okolo
Copy link
Contributor

@okolo okolo commented May 7, 2024

No description provided.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.88%. Comparing base (8186112) to head (f5a9b65).

Files Patch % Lines
oda_api/api.py 81.25% 3 Missing ⚠️
tests/test_plot_tools.py 80.00% 1 Missing ⚠️
tests/test_progress_report.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   58.64%   58.88%   +0.23%     
==========================================
  Files          23       23              
  Lines        4897     4918      +21     
==========================================
+ Hits         2872     2896      +24     
+ Misses       2025     2022       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@okolo okolo linked an issue May 7, 2024 that may be closed by this pull request
@okolo okolo added the test-live label May 7, 2024
@okolo okolo requested a review from dsavchenko May 7, 2024 14:55
Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the PR is misleading for the moment. It only changes the way how the callback is passed and doesn't deal with the token. To actually use the context file to get a token, the token.py needs to be updated.

oda_api/api.py Show resolved Hide resolved
oda_api/api.py Outdated Show resolved Hide resolved
@okolo okolo requested a review from dsavchenko May 8, 2024 07:25
@volodymyrss volodymyrss self-requested a review May 8, 2024 14:33
@volodymyrss
Copy link
Member

As mentioned, @okolo will look into the failed test (even if it's not because of the changes of this PR)

@okolo
Copy link
Contributor Author

okolo commented May 12, 2024

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

@volodymyrss
Copy link
Member

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

@okolo
Copy link
Contributor Author

okolo commented May 14, 2024

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

I've tried to run the notebook in jupyter. The error persists. Here is the notebook output
Show_and_Save_Products.html.zip

@volodymyrss
Copy link
Member

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

I've tried to run the notebook in jupyter. The error persists. Here is the notebook output Show_and_Save_Products.html.zip

Looks like there was some strange behavior with this product on the live instance, must be related to a recent update.
Anyway now it's passing.

@okolo okolo self-assigned this May 15, 2024
@volodymyrss volodymyrss merged commit 99bb6f5 into master May 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notebooks should have access to requesters oda token
3 participants