Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated constants TEMP_CELSIUS and TIME_MINUTES #300

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

bodny
Copy link
Contributor

@bodny bodny commented Jan 4, 2025

Fixes #299
Fixes #297
Fixes #291
Closes #296

@nelsonamen
Copy link

Its working 😁👍

@matte-oss
Copy link

Working for me
@ofalvai

@ofalvai ofalvai merged commit fed64a7 into ofalvai:main Jan 5, 2025
1 of 2 checks passed
@ofalvai
Copy link
Owner

ofalvai commented Jan 5, 2025

Thank you for the fix @bodny! I'm not a user of this integration anymore, so I couldn't test it end-to-end, but the unit tests pass now. Let me know if something is not right. I cut a new release that includes this PR.

@captaindaveman
Copy link

Nice one getting this fixed so quickly 🫡

@MacSiem
Copy link

MacSiem commented Jan 5, 2025

Great, now it works for me, thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants