Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom progress providers #97

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Add support for custom progress providers #97

merged 3 commits into from
Dec 28, 2024

Conversation

jh0x
Copy link
Contributor

@jh0x jh0x commented Dec 23, 2024

Add support for custom progress provider in form of lambda/funtction:

auto p = ProgressBar([&]{ return getValue(); }, {.out = &hide, .speed = 1, .show = false});
//                   ^^^^^^^^^^^^^^^^^^^^^^^^^

@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12494646274

Details

  • 38 of 38 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 99.109%

Totals Coverage Status
Change from base Build 12267205189: 0.04%
Covered Lines: 445
Relevant Lines: 449

💛 - Coveralls

@jh0x
Copy link
Contributor Author

jh0x commented Dec 24, 2024

I should look at that Python fail later.

Copy link
Owner

@oir oir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ty for this contribution. I will document the new feature and bump version / release soon.

@oir oir merged commit ce25c8a into oir:main Dec 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants