Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw4 #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hw4 #5

wants to merge 2 commits into from

Conversation

AlexanderKiselyov
Copy link
Collaborator

No description provided.

@AlexanderKiselyov AlexanderKiselyov changed the title Добавлено решение задания домашней работы 4 Hw4 Oct 29, 2021
src/js/toggle.js Outdated Show resolved Hide resolved
@@ -0,0 +1,154 @@
@import "reset.scss";

html {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше на body вешать, это не во всех браузерах сработает

display: block;
}

.toggle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не забывайте пользоваться вложенностью, для изоляции классов дочерних элементов при сборке

Copy link
Member

@BusinessDuck BusinessDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 Баллов, доделать с картинками сборку, чтобы вся статика была локально

src/index.html Outdated Show resolved Hide resolved
src/js/toggle.js Outdated Show resolved Hide resolved
Copy link
Member

@BusinessDuck BusinessDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выглядит получше

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants