Update from upstream repo kwsch/pk3DS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably need to use this in conjunction with the zonedata to yield an actual met location ID; but good enough for doc purposes. #146
use an object wrapper to check for modifications to only write back if things were changed not sure I like this setup Closes #235 misc refactoring in maison7/owse
Fix USUM mart location names
Fix SMTE CurrentAttack
Fix USUM species not appearing
Closes #246
Implement item randomization for static/gift PKM
Random Mega Form option for Static Editors
Misc additions
increase diagnostic ability for a textfile, pull out some properties that aren't used outside of the library #253
Add static/gift shiny lock removal option
range check on click move for typechart
ty @sora10pls for the list
Yay null behavior from uninitialized objects. Program boots now.
The logic failed to properly detect "GYM6" as a GYM trainer that needed to have Type themed Pokemon. Same for ELITE trainers. Type themed trainers still sometimes have non-typed Pokemon. Looking into that now. Also want to reduce duplicate Pokemon.
Suspected that Marshal.UnsafeAddrOfPinnedArrayElement was the culprit; just reuse the logic from PKHeX/pkNX/NHSE for safely generating an image. Closes #479
int / int when x/y < 0 will always show 0 when dividing raw ints :P
similar to earlier pkNX/pkhex commit; this wasn't an intended c# feature
Line 243: using calls Close() in the dispose implementation, which then closes the underlying MemoryStream. Fixes #486 Ideally, this should be rewritten, but it's old code and works for what it needs to do. Removed the useless `ref` inputs, as the reference is never replaced.
Added table of contents that featured information already in the readme and their website while adding a support and usage section detailing new members how they can contact other members and contributors and how to actually use the editor after downloading the zip file.
SOS slots were originally undocumented at the time the dumper was created, back when the game first released. In the years that passed, the mechanics became better understood. Just dump the slots and list the deduplicated allies for each slot. Closes #551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The remote
kwsch/pk3DShas some new changes that aren't in this fork.So, here they are, ready to be merged! 🎉
It's also worth noting that you're using an old version of Backstroke. At your earliest
convenience, please update to a newer version! Here's how:
http://backstroke.uswebhook from your repository.Login with Githubbutton.Thanks!
Created by Backstroke. I'm a bot!