-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use one request object #84
Conversation
@atanasenko since it seems you have experience in c++ programming. What do you think about that approach? A problem is that optional type. std::optional is not supported yet since esphome uses c++ 14. And I can not use the esphome::optional since this one is not available for my test script. That should run on my local window machine where I have the esphome source not available. |
I'm a java dev mostly, and have very limited experience with cpp, unfortunately. Most of what I did in those prs was copy-paste :) |
But I was looking at the transport code and I think requests could be batched, but on a lower, packet level. |
Well the you are pretty fast in copy and paste :D |
Yes that is true. But my goal with the request object is also to reduce the api. |
This approach is simple and allows batching of changes.
Currently work in progress.