Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions aiosqlite/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,15 @@ def __init__(
DeprecationWarning,
)

def _stop_running(self):
Copy link

@KolomboPulse KolomboPulse Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def _stop_running(self):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def _stop_running(self):

All review points are the same type: verbatim copy of a line change.

If you are not some kind of AI, would you mind expanding with clarifying comments ?

async def _stop_running(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async 

self._running = False
# PEP 661 is not accepted yet, so we cannot type a sentinel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    # PEP 661 is not accepted yet, so we cannot type a sentinel

self._tx.put_nowait(_STOP_RUNNING_SENTINEL) # type: ignore[arg-type]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    self._tx.put_nowait(_STOP_RUNNING_SENTINEL)  # type: ignore[arg-type]


function = partial(lambda: _STOP_RUNNING_SENTINEL)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    function = partial(lambda: _STOP_RUNNING_SENTINEL)

future = asyncio.get_event_loop().create_future()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    future = asyncio.get_event_loop().create_future()


self._tx.put_nowait((future, function))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    self._tx.put_nowait((future, function))


return await future

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return await future


@property
def _conn(self) -> sqlite3.Connection:
Expand Down Expand Up @@ -105,16 +110,16 @@ def run(self) -> None:
# futures)

tx_item = self._tx.get()
if tx_item is _STOP_RUNNING_SENTINEL:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        if tx_item is _STOP_RUNNING_SENTINEL:

break

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            break


future, function = tx_item

try:
LOG.debug("executing %s", function)
result = function()
LOG.debug("operation %s completed", function)
future.get_loop().call_soon_threadsafe(set_result, future, result)

if result is _STOP_RUNNING_SENTINEL:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            if result is _STOP_RUNNING_SENTINEL:

break

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                break

except BaseException as e: # noqa B036
LOG.debug("returning exception %s", e)
future.get_loop().call_soon_threadsafe(set_exception, future, e)
Expand All @@ -139,7 +144,7 @@ async def _connect(self) -> "Connection":
self._tx.put_nowait((future, self._connector))
self._connection = await future
except Exception:
self._stop_running()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            self._stop_running()

await self._stop_running()
Copy link

@KolomboPulse KolomboPulse Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            await 

self._connection = None
raise

Expand Down Expand Up @@ -180,7 +185,7 @@ async def close(self) -> None:
LOG.info("exception occurred while closing connection")
raise
finally:
self._stop_running()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        self._stop_running()

await self._stop_running()
Copy link

@KolomboPulse KolomboPulse Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        await 

self._connection = None

@contextmanager
Expand Down