Skip to content

Commit

Permalink
Merge pull request #68 from omniphx/analysis-8L1ymX
Browse files Browse the repository at this point in the history 
Applied fixes from StyleCI
  • Loading branch information
@omniphx
omniphx committed Oct 13, 2015
2 parents 6696693 + 08cd71d commit d34681e
Show file tree
Hide file tree
Showing 44 changed files with 1,339 additions and 1,132 deletions.
144 changes: 70 additions & 74 deletions spec/Omniphx/Forrest/Authentications/UserPasswordSpec.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,59 +2,58 @@

namespace spec\Omniphx\Forrest\Authentications;

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;

use GuzzleHttp\ClientInterface;
use GuzzleHttp\Message\ResponseInterface;
use GuzzleHttp\Message\RequestInterface;
use Omniphx\Forrest\Interfaces\StorageInterface;
use Omniphx\Forrest\Interfaces\RedirectInterface;
use Omniphx\Forrest\Interfaces\InputInterface;
use GuzzleHttp\Message\ResponseInterface;
use Omniphx\Forrest\Interfaces\EventInterface;
use Omniphx\Forrest\Interfaces\InputInterface;
use Omniphx\Forrest\Interfaces\RedirectInterface;
use Omniphx\Forrest\Interfaces\StorageInterface;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;

class UserPasswordSpec extends ObjectBehavior
{
function let(
public function let(
ClientInterface $mockedClient,
ResponseInterface $mockedResponse,
RequestInterface $mockedRequest,
StorageInterface $mockedStorage,
RedirectInterface $mockedRedirect,
InputInterface $mockedInput,
EventInterface $mockedEvent) {

$settings = array(
EventInterface $mockedEvent)
{
$settings = [
'authenticationFlow' => 'UserPassword',
'credentials' => array(
'credentials' => [
'consumerKey' => 'testingClientId',
'consumerSecret' => 'testingClientSecret',
'callbackURI' => 'callbackURL',
'loginURL' => 'https://login.salesforce.com',
'username' => '',
'password' => '',
'username' => '',
'password' => '',

),
'parameters' => array(
],
'parameters' => [
'display' => 'popup',
'immediate' => 'false',
'state' => '',
'scope' => '',
),
'instanceURL' => '',
],
'instanceURL' => '',
'authRedirect' => 'redirectURL',
'version' => '30.0',
'defaults' => array(
'version' => '30.0',
'defaults' => [
'method' => 'get',
'format' => 'json',
'compression' => false,
'compressionType' => 'gzip',
),
'language' => 'en_US'
);
],
'language' => 'en_US',
];

$mockedStorage->get('resources')->willReturn([
'sobjects' => '/services/data/v30.0/sobjects',
'sobjects' => '/services/data/v30.0/sobjects',
'connect' => '/services/data/v30.0/connect',
'query' => '/services/data/v30.0/query',
'theme' => '/services/data/v30.0/theme',
Expand All @@ -68,20 +67,20 @@ function let(
'flexiPage' => '/services/data/v30.0/flexiPage',
'search' => '/services/data/v30.0/search',
'quickActions' => '/services/data/v30.0/quickActions',
'appMenu' => '/services/data/v30.0/appMenu']);
'appMenu' => '/services/data/v30.0/appMenu', ]);
$mockedStorage->get('version')->willReturn([
'url' => 'resourceURLs']);
'url' => 'resourceURLs', ]);
$mockedStorage->getTokenData()->willReturn([
'access_token' => 'accessToken',
'id' => 'https://login.salesforce.com/id/00Di0000000XXXXXX/005i0000000xxxxXXX',
'instance_url' => 'https://na00.salesforce.com',
'token_type' => 'Oauth']);
'token_type' => 'Oauth', ]);
$mockedStorage->putTokenData(Argument::any())->willReturn(null);
$mockedStorage->put(Argument::any(),Argument::any())->willReturn(null);
$mockedStorage->put(Argument::any(), Argument::any())->willReturn(null);

$mockedClient->send(Argument::any())->willReturn($mockedResponse);
$mockedClient->createRequest(Argument::any(),Argument::any(),Argument::any())->willReturn($mockedRequest);
$mockedClient->post(Argument::any(),Argument::any(),Argument::any())->willReturn($mockedResponse);
$mockedClient->createRequest(Argument::any(), Argument::any(), Argument::any())->willReturn($mockedRequest);
$mockedClient->post(Argument::any(), Argument::any(), Argument::any())->willReturn($mockedResponse);

$this->beConstructedWith(
$mockedClient,
Expand All @@ -90,36 +89,35 @@ function let(
$mockedInput,
$mockedEvent,
$settings);

}

function it_is_initializable()
public function it_is_initializable()
{
$this->shouldHaveType('Omniphx\Forrest\Authentications\UserPassword');
}

function it_should_authenticate(
public function it_should_authenticate(
ResponseInterface $versionResponse,
ClientInterface $mockedClient)
{
$mockedClient->send(Argument::any())->shouldBeCalled(1)->willReturn($versionResponse);

$versionResponse->json()->shouldBeCalled()->willReturn([['version'=>'30.0'],['version'=>'31.0']]);
$versionResponse->json()->shouldBeCalled()->willReturn([['version' => '30.0'],['version' => '31.0']]);

$this->authenticate('url')->shouldReturn(null);
}

function it_should_refresh(
public function it_should_refresh(
ResponseInterface $mockedResponse,
StorageInterface $mockedStorage)
{
$mockedResponse->json()->shouldBeCalled()->willReturn(['key'=>'value']);
$mockedResponse->json()->shouldBeCalled()->willReturn(['key' => 'value']);
$mockedStorage->putTokenData(Argument::type('array'))->shouldBeCalled();

$this->refresh()->shouldReturn(null);
}

function it_should_return_the_request(
public function it_should_return_the_request(
ClientInterface $mockedClient,
RequestInterface $mockedRequest,
ResponseInterface $mockedResponse)
Expand All @@ -128,133 +126,132 @@ function it_should_return_the_request(

$mockedResponse->json()->shouldBeCalled()->willReturn('worked');

$this->request('url',['key'=>'value'])->shouldReturn('worked');
$this->request('url', ['key' => 'value'])->shouldReturn('worked');
}

function it_should_refresh_the_token_if_response_throws_error(
public function it_should_refresh_the_token_if_response_throws_error(
ClientInterface $mockedClient,
RequestInterface $mockedRequest)
{

$mockedClient->send($mockedRequest)->willThrow('\Omniphx\Forrest\Exceptions\TokenExpiredException');

//This might seem counter-intuitive. We are throwing an exception with the send() method, but we can't stop it. Since we are calling the send() method twice, the behavior is correct for it to throw an exception. Actual behavior would never throw the exception, it would return a response.
$this->shouldThrow('\Omniphx\Forrest\Exceptions\TokenExpiredException')->duringRequest('url',['key'=>'value']);
$this->shouldThrow('\Omniphx\Forrest\Exceptions\TokenExpiredException')->duringRequest('url', ['key' => 'value']);
}

function it_should_revoke_the_authentication_token(ClientInterface $mockedClient)
public function it_should_revoke_the_authentication_token(ClientInterface $mockedClient)
{
$mockedClient->post(Argument::type('string'),Argument::type('array'))->shouldBeCalled();
$mockedClient->post(Argument::type('string'), Argument::type('array'))->shouldBeCalled();
$this->revoke()->shouldReturn(null);
}

//Client

function it_should_return_the_versions(ResponseInterface $mockedResponse)
public function it_should_return_the_versions(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn(array('version'=>'29.0','version'=>'30.0'));
$mockedResponse->json()->shouldBeCalled()->willReturn(['version' => '29.0','version' => '30.0']);

$this->versions()->shouldReturn(array('version'=>'29.0','version'=>'30.0'));
$this->versions()->shouldReturn(['version' => '29.0','version' => '30.0']);
}

function it_should_return_resources(ResponseInterface $mockedResponse)
public function it_should_return_resources(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('versionURLs');

$this->resources()->shouldReturn('versionURLs');
}

function it_should_return_identity (ResponseInterface $mockedResponse)
public function it_should_return_identity(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->willReturn('Identity');

$this->identity()->shouldReturn('Identity');
}

function it_should_return_limits(
public function it_should_return_limits(
StorageInterface $mockedStorage,
ResponseInterface $mockedResponse)
{
$mockedStorage->get('version')->shouldBeCalled()->willReturn(array('url'=>'versionURL'));
$mockedStorage->get('version')->shouldBeCalled()->willReturn(['url' => 'versionURL']);
$mockedResponse->json()->shouldBeCalled()->willReturn('limits');

$this->limits()->shouldReturn('limits');
}

function it_should_return_describe(
public function it_should_return_describe(
StorageInterface $mockedStorage,
ResponseInterface $mockedResponse)
{
$mockedStorage->get('version')->shouldBeCalled()->willReturn(array('url'=>'versionURL'));
$mockedStorage->get('version')->shouldBeCalled()->willReturn(['url' => 'versionURL']);
$mockedResponse->json()->shouldBeCalled()->willReturn('describe');

$this->describe()->shouldReturn('describe');
$this->describe()->shouldReturn('describe');
}

function it_should_return_query(ResponseInterface $mockedResponse)
public function it_should_return_query(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('query');

$this->query('query')->shouldReturn('query');
}

function it_should_return_query_next(ResponseInterface $mockedResponse)
public function it_should_return_query_next(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('query');

$this->next('nextUrl')->shouldReturn('query');
}

function it_should_return_queryExplain(ResponseInterface $mockedResponse)
public function it_should_return_queryExplain(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('queryExplain');

$this->queryExplain('query')->shouldReturn('queryExplain');
}

function it_should_return_queryAll(ResponseInterface $mockedResponse)
public function it_should_return_queryAll(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('queryAll');

$this->queryAll('query')->shouldReturn('queryAll');
}

function it_should_return_quickActions(ResponseInterface $mockedResponse)
public function it_should_return_quickActions(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('quickActions');

$this->quickActions()->shouldReturn('quickActions');
}

function it_should_return_search(ResponseInterface $mockedResponse)
public function it_should_return_search(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('search');

$this->search('query')->shouldReturn('search');
}

function it_should_return_ScopeOrder(ResponseInterface $mockedResponse)
public function it_should_return_ScopeOrder(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('searchScopeOrder');

$this->scopeOrder()->shouldReturn('searchScopeOrder');
}

function it_should_return_searchLayouts(ResponseInterface $mockedResponse)
public function it_should_return_searchLayouts(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('searchLayouts');

$this->searchLayouts('objectList')->shouldReturn('searchLayouts');
}

function it_should_return_suggestedArticles(ResponseInterface $mockedResponse)
public function it_should_return_suggestedArticles(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('suggestedArticles');

$this->suggestedArticles('query')->shouldReturn('suggestedArticles');
}

function it_should_return_suggestedQueries(ResponseInterface $mockedResponse)
public function it_should_return_suggestedQueries(ResponseInterface $mockedResponse)
{
$mockedResponse->json()->shouldBeCalled()->willReturn('searchSuggestedQueries');

Expand All @@ -263,31 +260,30 @@ function it_should_return_suggestedQueries(ResponseInterface $mockedResponse)

//Resource class

function it_returns_a_resource(
public function it_returns_a_resource(
ClientInterface $mockedClient,
StorageInterface $mockedStorage,
RequestInterface $mockedRequest,
ResponseInterface $mockedResponse)
{
$mockedClient->createRequest(Argument::type('string'),Argument::type('string'),Argument::type('array'))->willReturn($mockedRequest);
$mockedClient->createRequest(Argument::type('string'), Argument::type('string'), Argument::type('array'))->willReturn($mockedRequest);
$mockedClient->send(Argument::any())->willReturn($mockedResponse);

$mockedResponse->json()->shouldBeCalled()->willReturn('jsonResource');
$mockedResponse->xml()->shouldBeCalled()->willReturn('xmlResource');

$mockedStorage->getTokenData()->willReturn(array(
'access_token' =>'abc',
'instance_url' =>'def',
'token_type' =>'bearer'));
$mockedStorage->getTokenData()->willReturn([
'access_token' => 'abc',
'instance_url' => 'def',
'token_type' => 'bearer', ]);

$this->request('uri',[])->shouldReturn('jsonResource');
$this->request('uri',['format'=>'xml'])->shouldReturn('xmlResource');
$this->request('uri', [])->shouldReturn('jsonResource');
$this->request('uri', ['format' => 'xml'])->shouldReturn('xmlResource');
}

function it_allows_access_to_the_guzzle_client(
public function it_allows_access_to_the_guzzle_client(
ClientInterface $mockedClient)
{
$this->getClient()->shouldReturn($mockedClient);
}

}
}
Loading

0 comments on commit d34681e

Please sign in to comment.