-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise CSV export by saving columns #2762
Draft
kelvin-muchiri
wants to merge
14
commits into
main
Choose a base branch
from
csv-export-save-columns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
csv-export-save-columns
branch
from
January 21, 2025 07:32
6fbd74c
to
c2c4644
Compare
save column build and update build after an Instance is saved. The previous optimisation technique saved the maximum number for each repeat group. This resulted in extra columns for submissions with less repeats than the maximum
kelvin-muchiri
force-pushed
the
csv-export-save-columns
branch
from
January 23, 2025 12:33
aca8dee
to
8359e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Build and save CSV export columns after an Instance is saved. The previous optimisation technique saved the maximum number for each repeat group. This resulted in extra columns for submissions with less repeats than the maximum.
Steps taken to verify this change does what is intended
Side effects of implementing this change
No extra columns in the CSV for records where a repeat group number is less than the maximum number
Before submitting this PR for review, please make sure you have:
Closes #