[Access] Make response for data providers consistent. #6846
+492
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6819-make-response-for-data-providers-consistent
…achuk/6819-make-response-for-data-providers-consistent
AndriiDiachuk
requested review from
Guitarheroua,
UlyanaAndrukhiv and
illia-malachyn
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6846 +/- ##
=======================================
Coverage 41.09% 41.09%
=======================================
Files 2118 2119 +1
Lines 185850 185880 +30
=======================================
+ Hits 76369 76387 +18
- Misses 103080 103092 +12
Partials 6401 6401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
engine/access/rest/websockets/data_providers/account_statuses_provider.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/account_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
Guitarheroua
approved these changes
Jan 9, 2025
engine/access/rest/websockets/data_providers/blocks_provider.go
Outdated
Show resolved
Hide resolved
AndriiDiachuk
requested review from
jordanschalm,
AlexHentschel,
durkmurder,
zhangchiqing and
Kay-Zee
as code owners
AndriiDiachuk
requested review from
janezpodhostnik and
tarakby
as code owners
…achuk/6819-make-response-for-data-providers-consistent
…providers-consistent
…achuk/6819-make-response-for-data-providers-consistent
AndriiDiachuk
removed request for
jordanschalm,
AlexHentschel,
durkmurder,
zhangchiqing,
Kay-Zee and
janezpodhostnik
…sistent' of github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6819-make-response-for-data-providers-consistent
peterargue
reviewed
Jan 21, 2025
engine/access/rest/websockets/data_providers/account_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
peterargue
reviewed
Jan 22, 2025
engine/access/rest/websockets/data_providers/account_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
peterargue
reviewed
Jan 22, 2025
engine/access/rest/websockets/data_providers/events_provider_test.go
Outdated
Show resolved
Hide resolved
peterargue
reviewed
Jan 22, 2025
engine/access/rest/websockets/data_providers/transaction_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
…sistent' of github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6819-make-response-for-data-providers-consistent
peterargue
approved these changes
Jan 22, 2025
peterargue
deleted the
AndriiDiachuk/6819-make-response-for-data-providers-consistent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6819