Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loopio connector: entry["id"] can apparently be a number, so convert to str #2909

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

Fixes DAN-868.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 1:33am

@rkuo-danswer rkuo-danswer changed the title entry["id"] can apparently be a number, so convert to str loopio connector: entry["id"] can apparently be a number, so convert to str Oct 25, 2024
@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 25, 2024 02:43
@rkuo-danswer rkuo-danswer merged commit b9781c4 into main Oct 25, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the bugfix/loopio branch October 25, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant