Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor theming #2993

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Minor theming #2993

merged 8 commits into from
Oct 30, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Oct 30, 2024

Theming

Screen.Recording.2024-10-29.at.8.00.57.PM.mov

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:09pm

@pablonyx pablonyx changed the title ensure functionality Minor theming Oct 30, 2024
@Weves Weves marked this pull request as ready for review October 30, 2024 16:27
@@ -108,7 +108,7 @@ export function BasicSelectable({
? "bg-background-chat-selected"
: "bg-hover"
: chat
? "bg-background-chat-hover"
? "hover:bg-background-chat-hover"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment on what chat means?

@@ -5,17 +5,23 @@ import React from "react";
export function HeaderTitle({
children,
chat,
backgroundToggled,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment here

@@ -8,7 +8,13 @@ import Link from "next/link";
import { useContext } from "react";
import { FiSidebar } from "react-icons/fi";

export default function FixedLogo({ chat }: { chat?: boolean }) {
export default function FixedLogo({
chat,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: improve naming

@pablonyx pablonyx added this pull request to the merge queue Oct 30, 2024
@pablonyx pablonyx removed this pull request from the merge queue due to a manual request Oct 30, 2024
@pablonyx pablonyx added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit f318e30 Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants