Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for malformatted starter messages #3080

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Nov 7, 2024

Description

Existing upgrade will work for anybody with well formatted json arrays as starter messages.

This PR accounts for the case where users have modified their starter messages or they no longer properly represent the format we expect.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:24pm

@pablonyx pablonyx marked this pull request as ready for review November 7, 2024 17:49
@pablonyx pablonyx changed the title account for malformatted starter messages Account for malformatted starter messages Nov 7, 2024
@pablonyx pablonyx force-pushed the robust_assistant_description branch from 9d2b84e to 0a59efe Compare November 8, 2024 18:21
@rkuo-danswer rkuo-danswer merged commit 950b1c3 into main Nov 8, 2024
6 of 7 checks passed
@rkuo-danswer rkuo-danswer deleted the robust_assistant_description branch November 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants