Remove ee

[pablonyx]

Description

Fully remove ee imports from non ee modules (use fetch_versioned instead)

New fetch_versioned method for functionality that has no functional non-ee equivalent (and raises exception for missing modules in ee enabled environments

How Has This Been Tested?

• Core EE flows tested (token rate limits, user groups, etc.)
• Authentication with multi tenancy enabled, disabled

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

• All of the automated tests pass
• All PR comments are addressed and marked resolved
• If there are migrations, they have been rebased to latest main
• If there are new dependencies, they are added to the requirements
• If there are new environment variables, they are added to all of the deployment methods
• If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
• Docker images build and basic functionalities work
• Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

• This PR should be backported (make sure to check that the backport attempt succeeds)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 9, 2024 7:26pm

[steyer-mika]

@pablodanswer Are you sure that this code worked? If I try to register a user (im on the main branch without ee turned on) I get the following error:
File "/app/danswer/auth/users.py", line 231, in create
tenant_id = await fetch_ee_implementation_or_noop(...)
TypeError: object function can't be used in 'await' expression

It seems that when EE is disabled, the function fetch_ee_implementation_or_noop returns a no-op lambda that directly yields the async_return_default_schema function object instead of calling it. This leads to the error because await is applied to the function object itself rather than the result of calling the function.

To fix this, I believe the no-op lambda should actually invoke async_return_default_schema with the provided arguments, like so:
return lambda *args, **kwargs: async_return_default_schema(*args, **kwargs)

But I am not sure (I am no python dev).