Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure everything has a default max height in selector form field #3174

Merged
merged 1 commit into from
Nov 20, 2024
Merged

ensure everything has a default max height in selector form field #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/src/components/admin/connectors/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,10 @@ export function SelectorFormField({
{container && (
<SelectContent
side={side}
className={maxHeight ? `max-h-[${maxHeight}]` : undefined}
className={`
${maxHeight ? `${maxHeight}` : "max-h-72"}
overflow-y-scroll
`}
container={container}
>
{options.length === 0 ? (
Expand Down
4 changes: 3 additions & 1 deletion web/src/components/llm/LLMList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ export const LlmList: React.FC<LlmListProps> = ({

return (
<div
className={`${scrollable ? "max-h-[200px] include-scrollbar" : "max-h-[300px]"} bg-background-175 flex flex-col gap-y-1 overflow-y-scroll`}
className={`${
scrollable ? "max-h-[200px] include-scrollbar" : "max-h-[300px]"
} bg-background-175 flex flex-col gap-y-1 overflow-y-scroll`}
>
{userDefault && (
<button
Expand Down
Loading