Assistant cleanup #3236
Merged
Assistant cleanup #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
reviewed
Nov 24, 2024
| @@ -458,9 +461,6 @@ def upsert_persona( | |||
| validate_persona_tools(tools) | |||
|
|
|||
| if persona: | |||
| if not builtin_persona and persona.builtin_persona: | |||
There was a problem hiding this comment.
let's just not allow builtins to be updated at all
There was a problem hiding this comment.
Think we may want to leave this as is for yaml change purposes
hagen-danswer
approved these changes
Nov 24, 2024
ahmadassaf
pushed a commit
to ahmadassaf/danswer
that referenced
this pull request
Nov 25, 2024
* minor cleanup * ensure users don't modify built-in attributes of assistants * update sidebar * k * update update flow + assistant creation
pablonyx
added a commit
that referenced
this pull request
Nov 26, 2024
* minor cleanup * ensure users don't modify built-in attributes of assistants * update sidebar * k * update update flow + assistant creation
pablonyx
added a commit
that referenced
this pull request
Nov 26, 2024
* minor cleanup * ensure users don't modify built-in attributes of assistants * update sidebar * k * update update flow + assistant creation
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.