Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File handling cleanup #3240

Merged
merged 3 commits into from
Nov 25, 2024
Merged

File handling cleanup #3240

merged 3 commits into from
Nov 25, 2024

Conversation

pablonyx
Copy link
Contributor

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 5:50pm

@pablonyx pablonyx changed the title Sites fix File handling cleanup Nov 24, 2024
@pablonyx pablonyx marked this pull request as ready for review November 24, 2024 17:46
@pablonyx pablonyx added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@pablonyx pablonyx added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit b625ee3 Nov 25, 2024
13 checks passed
ahmadassaf pushed a commit to ahmadassaf/danswer that referenced this pull request Nov 25, 2024
@pablonyx @ahmadassaf
File handling cleanup (onyx-dot-app#3240)
0739c34 
* fix google sites connector

* minior cleanup

* rm comments
@onimsha onimsha mentioned this pull request Nov 29, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagen-danswer hagen-danswer hagen-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @hagen-danswer