Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let users specify resourcing caps #3403

Merged
merged 8 commits into from
Dec 12, 2024
Merged

let users specify resourcing caps #3403

merged 8 commits into from
Dec 12, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 10, 2024 •
edited
Loading

Description

Fixes https://linear.app/danswer/issue/DAN-1147/add-option-for-resource-limits-in-compose-file-to-prevent-danswer-from

How Has This Been Tested?

  • Set no configuration
  • Set configuration + modify with environment variables + check resulting limits in Docker container each time

Accepted Risk (provide if relevant)

  • Poor defaults

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:31pm

@pablonyx pablonyx changed the title let users specify resourcing caps (wip) let users specify resourcing caps Dec 10, 2024
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Dec 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@pablonyx
let users specify resourcing caps (#3403)
f38c2cf 
* let users specify resourcing caps

* functioanl resource limits

* improve defaults

* k

* update

* update comment + refer to proper resource

* self nit

* update var names
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@pablonyx pablonyx added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 9cacb37 Dec 12, 2024
13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
@pablonyx
let users specify resourcing caps (onyx-dot-app#3403)
793ea03 
* let users specify resourcing caps

* functioanl resource limits

* improve defaults

* k

* update

* update comment + refer to proper resource

* self nit

* update var names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuo-danswer rkuo-danswer rkuo-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @rkuo-danswer