Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made external group emails lowercase #3410

Merged
merged 1 commit into from
Dec 10, 2024
Merged

made external group emails lowercase #3410

merged 1 commit into from
Dec 10, 2024

Conversation

hagen-danswer
Copy link
Contributor

Description

  • This fixes an issue where when we create a user in the db, the email is converted to lowercase but we still use the upercase one to match

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:20pm

pablonyx
pablonyx approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@pablonyx pablonyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to be able to assume that the values we're referring to are already normalized. This is likely something worth doing at the DB level if we're running into issues like these.

@hagen-danswer hagen-danswer added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 6d6e121 Dec 10, 2024
13 checks passed
@hagen-danswer hagen-danswer deleted the external-group-lowercase branch December 11, 2024 01:40
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
@hagen-danswer
made external group emails lowercase (onyx-dot-app#3410)
c700213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablonyx pablonyx pablonyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagen-danswer @pablonyx