Egnyte connector #3420
Merged
Egnyte connector #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
Dec 10, 2024
| desired_return_url = f"{WEB_DOMAIN}/admin/connectors/{source}?step=0" | ||
| redis_client = get_redis_client(tenant_id=tenant_id) | ||
| state = str(uuid.uuid4()) | ||
| redis_client.set(_OAUTH_STATE_KEY_FMT.format(state=state), desired_return_url) |
rkuo-danswer
approved these changes
Dec 10, 2024
| delay: float = 1, | ||
| backoff: float = 2, | ||
| ) -> requests.Response: | ||
| @retry(tries=tries, delay=delay, backoff=backoff, logger=cast(Logger, logger)) |
There was a problem hiding this comment.
couple of possible alternative approaches to think about in the future:
- set urllib3.Retry on the requests object
- tenacity Retry is better supported nowadays
|
|
||
| file_name = file_metadata["name"] | ||
| extension = get_file_ext(file_name) | ||
| if not check_file_ext_is_valid(extension): |
There was a problem hiding this comment.
nit: function naming is a bit redundant ... could be is_valid_file_ext
| return DocumentSource.EGNYTE | ||
|
|
||
| @classmethod | ||
| def redirect_uri(cls, base_domain: str, state: str) -> str: |
There was a problem hiding this comment.
this method is somewhat confusingly named ... the url being generated is the authorization url for the integration.
| current_batch = [] | ||
|
|
||
| except Exception as e: | ||
| logger.error(f"Failed to process file {file['path']}: {str(e)}") |
There was a problem hiding this comment.
logger.exception usually easier to use (implicitly logs exceptions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a new "standard" approach to adding oauth based connectors.