Increase password requirements #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
prevent_login_bruteforce
branch
from
8f8dffe to
e6f9466
Compare
pablonyx
force-pushed
the
prevent_login_bruteforce
branch
from
6940288 to
0c10c14
Compare
rkuo-danswer
approved these changes
Dec 14, 2024
backend/onyx/auth/users.py
Outdated
| ) | ||
| if not any(char in "!@#$%^&*()_+-=[]{}|;:,.<>?" for char in password): | ||
| raise exceptions.InvalidPasswordException( | ||
| reason="Password must contain at least one special character (!@#$%^&*()_+-=[]{}|;:,.<>?)." |
There was a problem hiding this comment.
Special characters feels like the kind of thing we should declare as a constant somewhere.
pablonyx
force-pushed
the
prevent_login_bruteforce
branch
from
5d44810 to
1557c7d
Compare
pablonyx
force-pushed
the
prevent_login_bruteforce
branch
from
1557c7d to
334bc6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1184/login-bruteforce
How Has This Been Tested?
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.