errors in the summary row should be counting last_finished_status as … #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reflected in the per connector rows
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…fix/connector_error_count
pablonyx
approved these changes
Dec 16, 2024
|
Looks great! This will clear up the indexing status page quite a bit |
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Dec 23, 2024
…reflected in the per connector rows (onyx-dot-app#3484) Co-authored-by: Richard Kuo (Danswer) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reflected in the per connector rows
Description
Fixes DAN-1198.
How Has This Been Tested?
Observed error count in summary row now does not decrease if indexing for a previously connector is in progress.
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.