Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap nits #3496

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Wrap nits #3496

merged 5 commits into from
Dec 18, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 17, 2024

Description

Fixes https://linear.app/danswer/issue/DAN-1201/few-small-uiux-improvements

Screenshot 2024-12-17 at 2 01 05 PM Screenshot 2024-12-17 at 1 59 51 PM Screenshot 2024-12-17 at 1 54 30 PM Screenshot 2024-12-17 at 2 00 01 PM

How Has This Been Tested?

Verify UI (of features) on various screen sizes with multiple tag sizes

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:57am

@yuhongsun96
Copy link
Contributor

image

Overflowing

@yuhongsun96 yuhongsun96 merged commit ddc6a6d into main Dec 18, 2024
9 checks passed
@yuhongsun96 yuhongsun96 deleted the extracted_nits branch December 18, 2024 02:03
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants