Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding <place> tags to Ithaca (17). #41

Merged
merged 6 commits into from
Nov 21, 2017
Merged

Adding <place> tags to Ithaca (17). #41

merged 6 commits into from
Nov 21, 2017

Conversation

charlesreid1
Copy link
Contributor

Many of the tags do not contain detailed information.
However, adding tags will make it easier to go back and
parse/expand on the existing place names to fill in with more details,
more like issue #27 at open-editions/corpus-joyce-ulysses-tei and the
suggested by Caleb.

This follows Places
guidelines from TEI and doesn't deviate much from its examples.

Many of the <place> tags do not contain detailed information.
However, adding <place> tags will make it easier to go back and
parse/expand on the existing place names to fill in with more details,
more like issue #27 at open-editions/corpus-joyce-ulysses-tei and the
suggested by Caleb.

This follows [Places](http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ND.html#NDGEOG)
guidelines from TEI and doesn't deviate much from its examples.
@charlesreid1
Copy link
Contributor Author

charlesreid1 commented Nov 18, 2017

This also adds two cross-references, one within Ithaca (Sinbad the Sailor) and one external (buying the soap in Lotus Eaters).

The within-document reference looks like this:

<ref target="#lb_172322"><title type="pantomime">Sinbad the Sailor</title></ref> (produced by R Shelton 26 December 1892,
<p rend="non-indent"><lb n="172322" xml:id="lb_172322"/>Sinbad the Sailor and Tinbad the Tailor and Jinbad the Jailer and Whinbad

while the external-document reference looks like this:

<ref target="u05_lotus-eaters.xml#lb_050513">(bought thirteen hours
<lb n="170233"/>previously for fourpence and still unpaid for)</ref>,
<lb n="050513" xml:id="lb_050513"/><said who="lb">―I'll take this one,</said> he said. <said who="lb">That makes three and a penny.</said>

These implement the <ref> and xml:id suggestions from #23, but cross-reference events in addition to re-used phrases (also see #39 cross-reference between Wandering Rocks and Oxen of the Sun). This should help locate some of the cross-references once a convention has been settled upon.

@charlesreid1
Copy link
Contributor Author

Removed tags per #39, will re-implement these references in a later PR.

@charlesreid1 charlesreid1 changed the title Adding <place> tags to Ithaca. ~20% complete. Adding <place> tags to Ithaca (17). Nov 21, 2017
@charlesreid1
Copy link
Contributor Author

This pull request is now ready to merge!

@yellwork yellwork merged commit b59bb15 into open-editions:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants