-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding <place> tags to Ithaca (17). #41
Adding <place> tags to Ithaca (17). #41
Conversation
Many of the <place> tags do not contain detailed information. However, adding <place> tags will make it easier to go back and parse/expand on the existing place names to fill in with more details, more like issue #27 at open-editions/corpus-joyce-ulysses-tei and the suggested by Caleb. This follows [Places](http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ND.html#NDGEOG) guidelines from TEI and doesn't deviate much from its examples.
This also adds two cross-references, one within Ithaca (Sinbad the Sailor) and one external (buying the soap in Lotus Eaters). The within-document reference looks like this:
while the external-document reference looks like this:
These implement the |
…e-ulysses-tei into ithaca-place-tags * 'master' of https://github.com/open-editions/corpus-joyce-ulysses-tei: update Travis URL in badge for #37 another attempt to fix travis config attempt to fix travis config Repairing xml:id tags
Removed tags per #39, will re-implement these references in a later PR. |
This pull request is now ready to merge! |
Many of the tags do not contain detailed information.
However, adding tags will make it easier to go back and
parse/expand on the existing place names to fill in with more details,
more like issue #27 at open-editions/corpus-joyce-ulysses-tei and the
suggested by Caleb.
This follows Places
guidelines from TEI and doesn't deviate much from its examples.