-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where sent tapbacks would go from blue to transparent depending on where you were scrolled #56
Open
sabogalc
wants to merge
12
commits into
open-imcore:master
Choose a base branch
from
sabogalc:csab/fix/transparent-tapbacks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed an issue where sent tapbacks would go from blue to transparent depending on where you were scrolled #56
sabogalc
wants to merge
12
commits into
open-imcore:master
from
sabogalc:csab/fix/transparent-tapbacks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the acknowledgment menu more dark mode friendly
…mentPicker.scss`
…t, so now I'm undoing that mistake. My bad.
…nts would go transparent
…chments at a smaller size
…depending on where you were scrolled
For both this pull request and this one, I no longer want to use the previous hardcoded blue values that I selected, but rather, I want to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this by changing the
--bubble-from-me-bg: var(--imessage-gradient)
line to a hardcoded value ofrgb(0, 119, 248)
. Below is a before/after video comparison.React.Redux.App.-.Brave.2021-06-29.18-43-28.mp4
React.Redux.App.-.Brave.2021-06-29.18-43-53.mp4