Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Permissions on TestSuite and TestCases #19072

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

User Permissions on TestSuite and TestCases #19072

wants to merge 11 commits into from
+3,626 −112

Conversation

harshach
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner December 14, 2024 22:27
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 14, 2024
TeddyCr
TeddyCr previously approved these changes Dec 16, 2024
View reviewed changes
IceS2
IceS2 previously approved these changes Dec 17, 2024
View reviewed changes
@harshach harshach dismissed stale reviews from IceS2 and TeddyCr via 7c398cf January 2, 2025 23:18
TeddyCr
TeddyCr reviewed Jan 14, 2025
View reviewed changes
...data-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java
@@ -724,7 +725,8 @@ public Response delete(
@Parameter(description = "FQN of the logical test suite", schema = @Schema(type = "String"))
@PathParam("name")
String name) {
OperationContext operationContext = new OperationContext(entityType, MetadataOperation.DELETE);
OperationContext operationContext =
new OperationContext(Entity.TEST_SUITE, MetadataOperation.DELETE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't entityType be the same as Entity.TEST_SUITE?

TeddyCr
TeddyCr previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaileshParmar11
Improvement: Revamp the permissions for testCase & testSuite details …
6fd45fe 
…page (#19137)

* Feat: revamp the permissions in test case and test suite details page

* minor fixes

* added permission checks for test case details page
@ShaileshParmar11 ShaileshParmar11 requested a review from a team as a code owner January 20, 2025 06:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr left review comments

@IceS2 IceS2 IceS2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshach @IceS2 @TeddyCr @ShaileshParmar11