Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new blog post "Observing Lambdas" #5990

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

theSuess
Copy link

@theSuess theSuess commented Jan 20, 2025

@opentelemetrybot opentelemetrybot requested a review from a team January 20, 2025 12:05
@github-actions github-actions bot added the blog label Jan 20, 2025
Comment on lines 103 to 105
<video controls>
<source src="./video-lambda-real-time.webm" />
</video>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is fitting. Screenshots would work here as well but IMHO a video better shows this working in action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with adding a video, maybe we can scale it down a little bit since it adds ~2MB to the git tree.

See my other comment. This way we can not accept the video as it points to a commercial backend.

Also, if you look at the preview the video is breaking the HTML:

https://deploy-preview-5990--opentelemetry.netlify.app/blog/2025/observing-lambdas/

You need to fine tune that to fit into the page.


Personally I prefer a self-contained text blog post, that also provides me with a quick way to setup a backend and send data their. I understand that in this particular case it's a little bit tricky because you can not simply run jaeger on your mac and need something running in AWS, so the video would be fine, if it fits the criteria.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the video would be fine, as long as the URL and data source name don't contain grafanacloud or grafana.net? If that's the case, I'll re-record it with a local instance and fit it to the content size


I've also considered something self-contained, but as you mentioned, the work of setting up something local and tunneling data there would be more than the rest of the content.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm I've re-recorded the video on an open source instance so it no longer contains any references to any commercial offerings. I've also compressed it down to 553KiB. It is also contained to the width of the article now (tested on smaller screens & on mobile)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another strategy would be to post this video on YouTube and embed a link to it in the post (either as a simply link or using https://gohugo.io/shortcodes/youtube/.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few copy edits. Thanks!

content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
@tiffany76
Copy link
Contributor

Sorry, I got ahead of you @theSuess! I just realized this was still in draft.

@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 09:52
@theSuess
Copy link
Author

All good, I've set this to draft because of concerns whether a video is suitable, but it seems like there is no objection, so I'm promoting this PR as ready to review :)

@theSuess theSuess marked this pull request as ready for review January 24, 2025 09:54
@theSuess theSuess requested a review from a team as a code owner January 24, 2025 09:54
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a copy edit perspective.

content/en/blog/2025/observing-lambdas/index.md Outdated Show resolved Hide resolved
theSuess and others added 14 commits January 24, 2025 17:33
@chalin chalin force-pushed the blog/observing-lambdas branch from 4992595 to 7f6a19a Compare January 24, 2025 22:33
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 22:33
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 22:38
@opentelemetrybot opentelemetrybot requested a review from a team January 24, 2025 22:38
@chalin
Copy link
Contributor

chalin commented Jan 24, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12958806461

<video controls style="width: 100%">
<source src="./video-lambda-real-time.webm" />
</video>
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add something at the end here to "wrap up" / offer some closing words?

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants