-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new blog post "Observing Lambdas" #5990
base: main
Are you sure you want to change the base?
Conversation
<video controls> | ||
<source src="./video-lambda-real-time.webm" /> | ||
</video> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is fitting. Screenshots would work here as well but IMHO a video better shows this working in action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issue with adding a video, maybe we can scale it down a little bit since it adds ~2MB to the git tree.
See my other comment. This way we can not accept the video as it points to a commercial backend.
Also, if you look at the preview the video is breaking the HTML:
https://deploy-preview-5990--opentelemetry.netlify.app/blog/2025/observing-lambdas/
You need to fine tune that to fit into the page.
Personally I prefer a self-contained text blog post, that also provides me with a quick way to setup a backend and send data their. I understand that in this particular case it's a little bit tricky because you can not simply run jaeger on your mac and need something running in AWS, so the video would be fine, if it fits the criteria.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the video would be fine, as long as the URL and data source name don't contain grafanacloud
or grafana.net
? If that's the case, I'll re-record it with a local instance and fit it to the content size
I've also considered something self-contained, but as you mentioned, the work of setting up something local and tunneling data there would be more than the rest of the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm I've re-recorded the video on an open source instance so it no longer contains any references to any commercial offerings. I've also compressed it down to 553KiB. It is also contained to the width of the article now (tested on smaller screens & on mobile)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another strategy would be to post this video on YouTube and embed a link to it in the post (either as a simply link or using https://gohugo.io/shortcodes/youtube/.
ed6c07d
to
7c5394a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few copy edits. Thanks!
Sorry, I got ahead of you @theSuess! I just realized this was still in draft. |
All good, I've set this to draft because of concerns whether a video is suitable, but it seems like there is no objection, so I'm promoting this PR as ready to review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a copy edit perspective.
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
4992595
to
7f6a19a
Compare
Co-authored-by: Tiffany Hrabusa <[email protected]>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12958806461 |
<video controls style="width: 100%"> | ||
<source src="./video-lambda-real-time.webm" /> | ||
</video> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add something at the end here to "wrap up" / offer some closing words?
IMPORTANT: (RE-)RUN
|
Tracking issue #5961
Preview: https://deploy-preview-5990--opentelemetry.netlify.app/blog/2025/observing-lambdas/